[kcmkwin/kwindecoration] Refine drag-and-drop button UI
ClosedPublic

Authored by ngraham on Thu, May 2, 7:17 PM.

Details

Summary
  • Reduce the fake titlebar's height so it matches the real titlebar a bit better
  • Reduce background opacity while dropping button to diminish visual noise
  • Increase label size
  • Re-word label for greater clarity
  • Remove redundant icon (the text is enough)

BUG: 407109
FIXED-IN: 5.16.0

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Thu, May 2, 7:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptThu, May 2, 7:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Thu, May 2, 7:17 PM

(KWin already has a runtime dependency on Kirigami so hopefully importing it in this file shouldn't be a problem)

GB_2 added a subscriber: GB_2.Thu, May 2, 7:28 PM

Nice! Could you also maybe set titleBarSpacing to units.smallSpacing * 2, so the titlebar spacing isn't so huge and looks much better?

kcmkwin/kwindecoration/package/contents/ui/Buttons.qml
225

I think it would be fine without bold font.

I tried removing the label's boldness but then the it didn't seem quite visible enough. Good call on the titlebar height though.

ngraham updated this revision to Diff 57397.Thu, May 2, 7:33 PM

Also reduce titlebar height

GB_2 accepted this revision.Thu, May 2, 7:35 PM
This revision is now accepted and ready to land.Thu, May 2, 7:35 PM
ngraham retitled this revision from [kcmkwin/kwindecoration] Refine drag-and-drop button removal UI to [kcmkwin/kwindecoration] Refine drag-and-drop button UI.Thu, May 2, 7:35 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Thu, May 2, 10:45 PM
This revision was automatically updated to reflect the committed changes.