Differential D20893

Accept games by name as a parameter to --solve.
ClosedPublic
Actions

Authored by shlomif on Apr 29 2019, 10:54 AM.

Details

Reviewers
aacid
Group Reviewers
KDE Games

Diff Detail

Repository
R410 KPatience
Branch
accept-games-by-name
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11335
Build 11353: arc lint + arc unit
shlomif created this revision.Apr 29 2019, 10:54 AM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 29 2019, 10:54 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.Apr 29 2019, 10:54 AM
aacid accepted this revision.May 13 2019, 9:39 PM
aacid added a subscriber: aacid.

Looks good to me, you can commit, if you want to do the fixes to make me happier, better (no need to have another review), if not, it's just going to be 0.0000000001 seconds slower, so no big need :D

main.cpp
65

const QString &

214

QString() instead of ""

This revision is now accepted and ready to land.May 13 2019, 9:39 PM
shlomif closed this revision.Jun 1 2019, 12:19 PM

Merged, thanks!

Revision Contents
Changeset List

PathPackages
Mautotests/CMakeLists.txt (6 lines)
AMautotests/solve_by_name.cpp (44 lines)
Mmain.cpp (22 lines)

Diff 57168

View Options

autotests/CMakeLists.txt

Loading...
View Options

autotests/solve_by_name.cpp

Loading...
View Options

main.cpp

Loading...