Differential D2085

[effects] Adjust SlidingPopups to new windowShown and windowHidden signals
ClosedPublic
Actions

Authored by graesslin on Jul 4 2016, 1:42 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:c6b25627105a: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals
Summary

With this change SlidingPopups is able to animate Wayland clients
properly, though windowHidden does not yet work for OpenGL based
windows (buffer seems to get lost somewhere).

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4940.Jul 4 2016, 1:42 PM
graesslin retitled this revision from to [effects] Adjust SlidingPopups to new windowShown and windowHidden signals.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 4 2016, 1:42 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Jul 12 2016, 9:23 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.
sebas added inline comments.
effects/slidingpopups/slidingpopups.cpp
200

clean up, or is this useful to keep around as a comment?

This revision is now accepted and ready to land.Jul 12 2016, 9:23 PM
graesslin marked an inline comment as done.Jul 13 2016, 8:49 AM
Closed by commit R108:c6b25627105a: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals (authored by graesslin). · Explain WhyJul 13 2016, 8:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5118

View Options

effects/slidingpopups/slidingpopups.h

Loading...
View Options

effects/slidingpopups/slidingpopups.cpp

Loading...