Use hiddenInternal() for a ShellClient which got unmapped
ClosedPublic

Authored by graesslin on Jul 4 2016, 1:36 PM.

Details

Summary

So far when a ShellClient got unmapped ready_for_painting was set to
false. That is the ShellClient was treated in the same way as a not
yet shown window. It was completely excluded from painting, a close
animation impossible.

This change makes use of the functionality available in
Client::hiddenInternal(). The window is considered as hidden, thus
still excluded from e.g. getting input events, but could be rendered
any time as we still have a previous window pixmap (if referenced).
This allows to have it considered in the rendering pass, but effects
still cannot make use of it as that state is not yet exposed to the
effects.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4938.Jul 4 2016, 1:36 PM
graesslin retitled this revision from to Use hiddenInternal() for a ShellClient which got unmapped.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 4 2016, 1:36 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Jul 12 2016, 9:19 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jul 12 2016, 9:19 PM
This revision was automatically updated to reflect the committed changes.