Add runner for geo uris
ClosedPublic

Authored by kossebau on Jul 4 2016, 6:39 AM.

Details

Summary

Supports only geo uris with CRS mathcing the current globe

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 4922.Jul 4 2016, 6:39 AM
kossebau retitled this revision from to Add runner for geo uris.
kossebau updated this object.
kossebau added reviewers: Marble, rahn, nienhueser.
nienhueser added inline comments.Jul 5 2016, 3:26 AM
src/plugins/runner/geouri/GeoUriPlugin.h
29

We should use that (the override keyword) at more places, me thinks.

src/plugins/runner/geouri/GeoUriRunner.cpp
63

What is the idea here? Use the altitude for zooming? The zoomLevel property is not used for that IIRC.

kossebau added inline comments.Jul 5 2016, 10:43 AM
src/plugins/runner/geouri/GeoUriRunner.cpp
63

Yes, seems that is clueless code :) Inspired from FileLoaderPrivate::createFilterProperties and what it does for // Mountain (H), Volcano (V), Shipwreck (W).
But right, now looking at the API dox of GeoDataFeature::setZoomLevel() this is complete bogus, and I just should set it to 1, so the search result is always shown.

kossebau updated this revision to Diff 4957.Jul 5 2016, 10:50 AM

Removed bogus zoomlevel setting

nienhueser accepted this revision.Jul 9 2016, 3:25 PM
nienhueser edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 9 2016, 3:25 PM
This revision was automatically updated to reflect the committed changes.