kpackagetool: read kpackage-generic.desktop from qrc

Authored by dfaure on Apr 22 2019, 9:17 PM.


Test Plan

(to mimick CI) : make uninstall in kpackage and then
QT_LOGGING_RULES='*=true' XDG_DATA_DIRS=$KDEDIR/share /d/kde/build/5/frameworks/kpackage/bin/kpackagetool5 --appstream-metainfo . --appstream-metainfo-output /tmp/a.xml

For some reason kpackagetool5 creates a KPluginMetaData from
metadata.desktop in 3 different places of the code
(Package::setPath calls metadata() but then it deletes it!, metadata() again later, and PackageTool::showAppstreamInfo)

Before: Unknown property type for key "X-Plasma-MainScript" -> falling back to string
After: No more warning

Diff Detail

R290 KPackage
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Apr 22 2019, 9:17 PM
dfaure created this revision.
apol accepted this revision.Apr 23 2019, 12:02 AM
This revision is now accepted and ready to land.Apr 23 2019, 12:02 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 27 2019, 2:17 PM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald Transcript