Differential D20743

[Kicker] Modernize settings window
ClosedPublic
Actions

Authored by ngraham on Apr 22 2019, 6:20 PM.

Details

Reviewers
hein
GB_2
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R119:2e2cfa891534: [Kicker] Modernize settings window
Summary

Port Kicker's settings window to Kirigami+FormLayout and QQC2.

Test Plan

All features tested and still work.

Diff Detail

Repository
R119 Plasma Desktop
Branch
modernize-kicker-settings (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11117
Build 11135: arc lint + arc unit
ngraham created this revision.Apr 22 2019, 6:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 22 2019, 6:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 22 2019, 6:20 PM
hein accepted this revision.Apr 22 2019, 6:39 PM
This revision is now accepted and ready to land.Apr 22 2019, 6:39 PM
GB_2 accepted this revision.Apr 22 2019, 6:42 PM
GB_2 added a subscriber: GB_2.

Looks good

applets/kicker/package/contents/ui/ConfigGeneral.qml
194

Categories -> categories

ngraham updated this revision to Diff 56764.Apr 22 2019, 6:43 PM
ngraham marked an inline comment as done.

Use correct casing for label

ngraham edited the test plan for this revision. (Show Details)Apr 22 2019, 6:48 PM
Closed by commit R119:2e2cfa891534: [Kicker] Modernize settings window (authored by ngraham). · Explain WhyApr 22 2019, 6:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56761

View Options

applets/kicker/package/contents/config/config.qml

Loading...
View Options

applets/kicker/package/contents/ui/ConfigGeneral.qml

Loading...