Differential D20728

Adapt to printing model changes
ClosedPublic
Actions

Authored by vkrause on Apr 22 2019, 10:15 AM.

Details

Reviewers
dvratil
Commits
R204:6722b1e1efb8: Adapt to printing model changes

Diff Detail

Repository
R204 KAddressBook
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 22 2019, 10:15 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2019, 10:15 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 22 2019, 10:15 AM
knauss added a subscriber: knauss.Apr 24 2019, 8:34 PM

Please add a simple test case to make sure we catch those changes by tests.

vkrause added a comment.Apr 26 2019, 2:04 PM
In D20728#455577, @knauss wrote:

Please add a simple test case to make sure we catch those changes by tests.

There's tests for this in kdepim-apps-libs already. And while I agree that having more tests here makes sense in a perfect world, it seems like a rather heavy requirement for these cleanups and fixes, considering there is not a single unit test in here atm.

dvratil accepted this revision.May 2 2019, 3:25 PM
This revision is now accepted and ready to land.May 2 2019, 3:25 PM
Closed by commit R204:6722b1e1efb8: Adapt to printing model changes (authored by vkrause). · Explain WhyMay 3 2019, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 57470

View Options

CMakeLists.txt

Loading...