Differential D20727

Port Grantlee contact printing model to KContacts::Addressee too
ClosedPublic
Actions

Authored by vkrause on Apr 22 2019, 10:15 AM.

Details

Reviewers

Commits

R82:69c11af3e25a: Port Grantlee contact printing model to KContacts::Addressee too

Summary

This means for the data both display and printing now use the same model,
so improvements to that will benefit both sides. Printing however isn't
able to use i18n in the templates yet, so we can't remove the i18n
properties here yet.

Diff Detail

Repository

R82 KDE PIM Application Libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Apr 22 2019, 10:15 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2019, 10:15 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Apr 22 2019, 10:15 AM

Harbormaster completed remote builds in B11089: Diff 56716.Apr 22 2019, 10:15 AM

dvratil added a subscriber: dvratil.Apr 28 2019, 3:36 PM

dvratil added inline comments.

kaddressbookgrantlee/src/printing/autotests/grantleeprinttest.cpp
107–109	Does this needs adjustments in the printing templates as well?
kaddressbookgrantlee/src/printing/grantleeprint.cpp
95	The `reinterpret_cast` looks very shady, hopefully, we can get rid of it soon.

Remove the need for using reinterpret_cast.

Harbormaster completed remote builds in B11398: Diff 57303.May 1 2019, 10:17 AM

vkrause added inline comments.May 1 2019, 10:18 AM

kaddressbookgrantlee/src/printing/autotests/grantleeprinttest.cpp
107–109	Yep, done in D20728.

dvratil accepted this revision.May 2 2019, 3:24 PM

This revision is now accepted and ready to land.May 2 2019, 3:24 PM

Closed by commit R82:69c11af3e25a: Port Grantlee contact printing model to KContacts::Addressee too (authored by vkrause). · Explain WhyMay 3 2019, 3:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		kaddressbookgrantlee/src/CMakeLists.txt (16 lines)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleecryptoobject.h (42 lines)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleecryptoobject.cpp (47 lines)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleeimobject.h (42 lines)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleeimobject.cpp (43 lines)
M		kaddressbookgrantlee/src/contactobject/contactgrantleewrapper.h (16 lines)
M		kaddressbookgrantlee/src/contactobject/contactgrantleewrapper.cpp (46 lines)
M		kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp (3 lines)
M		kaddressbookgrantlee/src/printing/autotests/grantleeprinttest.cpp (7 lines)
D	M	kaddressbookgrantlee/src/printing/contactgrantleeprintobject.h (111 lines)
D	M	kaddressbookgrantlee/src/printing/contactgrantleeprintobject.cpp (272 lines)
M		kaddressbookgrantlee/src/printing/grantleeprint.cpp (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56716	ca58c05		Apr 22 2019, 10:15 AM	★	★
Diff 2	57303	936e7d1	Remove the need for using reinterpret_cast.	May 1 2019, 10:17 AM	★	★
Diff 3	57469	936e7d1	R82:69c11af3e25a38d4e2a2864f9095c48968143cac	May 3 2019, 3:51 PM	★	★