Add an alternative to list-remove, which needs to be next to list-add for context and edit-delete, which is a destructive deletion icon.
Symlink from edit-remove to paint-none.
Details
- Reviewers
ndavis - Group Reviewers
VDG - Commits
- R266:7c6559bdb86f: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit…
Search for edit-remove in Cuttlefish.
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- add-edit-remove-icon (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11087 Build 11105: arc lint + arc unit
Oops, forgot that paint-none already exists, which looks like this. I will just make a symlink then.
alternative to list-remove, which needs to be next to list-add for context
list-remove is just a minus icon, which has no context and looks weird when used alone, without list-add next to it. An example where the new icon can be used is D20576.
We have a problem where we don't use consistent iconography for "remove". Sometimes it's a normal minus, sometimes it's a red minus, sometimes it's a red X and sometimes it's a red trash can (the line between "delete" and "remove" can be blurry). I think adding an edit-remove icon would likely cause more confusion, first for developers and then for users. I don't think using a minus without a plus is a problem, but perhaps the minus should be made red?
A trash can in a list like D20576 would look like you're deleting something entirely and a red minus would still have the context problem like I said. The GNOME HIG even has a rule for this (https://developer.gnome.org/hig/stable/icons-and-artwork.html):
- Remember that some icons are only meaningful alongside other icons of the same type. For example, a media icon for stop is simply a square, and may not be identified as a stop icon without other media controls (like play, pause, or skip) being visible close by. Likewise, the icon to remove an item from a list is a subtract symbol (i.e. a single line), and will not be recognizable without a corresponding “plus” add icon.
Yeah, I think the current minus icon is similar in that it's only meaningful next to a plus sign. So if we had a user interface with conjoined or adjacent plus and minus buttons, using that icon would make sense. But for removing a specific list item, I think this "X-style" icon is better. The trash can icon has a connotation of "this thing will be destroyed" that only applies to some list item removals.
The 22px version needs to have 1px thick lines and 3px margins on each side. An easy way to do that would be to just copy edit-none and use the node selector with guides to extend the ends of each line out. It would also be good to make the 16px version more like edit-none while you're at it.
Sorry to keep putting you through more hoops. It needs to be more like center version in this SVG (basically edit-none, but red):
Notice how the lines appear to have a thickness more similar to the square outline above while the original version on the right appears to be thicker.