Differential D2070

Support dropping of geo coordinates/geouris on the mapview & focus on them
ClosedPublic
Actions

Authored by kossebau on Jul 3 2016, 8:00 PM.

Details

Reviewers
nienhueser
rahn
Group Reviewers
Marble
Commits
R34:7b68c803e365: Support dropping of geo coordinates/geouris on the mapview & focus on them

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 4914.Jul 3 2016, 8:00 PM
kossebau retitled this revision from to Support dropping of geo coordinates/geouris on the mapview & focus on them.
kossebau added reviewers: Marble, rahn, nienhueser.
nienhueser accepted this revision.Jul 3 2016, 9:56 PM
nienhueser edited edge metadata.

Any chance to reduce the redundancy a bit with a helper method? Looks good otherwise.

This revision is now accepted and ready to land.Jul 3 2016, 9:56 PM
kossebau added a comment.Jul 3 2016, 10:44 PM
In D2070#38308, @nienhueser wrote:

Any chance to reduce the redundancy a bit with a helper method? Looks good otherwise.

No immediate idea. If openGeoUri() and GeoDataCoordinates::fromString() could be refactored and parsing of geo uris and coordinates would be aligned more in the pattern, it might be possible perhaps.

Closed by commit R34:7b68c803e365: Support dropping of geo coordinates/geouris on the mapview & focus on them (authored by kossebau). · Explain WhyJul 3 2016, 10:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4918

View Options

src/apps/marble-ui/ControlView.h

Loading...
View Options

src/apps/marble-ui/ControlView.cpp

Loading...