Fix no member named 'setTime_t' in 'QDateTime' error while building
ClosedPublic

Authored by shubham on Sat, Apr 20, 6:38 AM.

Details

Summary

BUG: 405554

setTime_t() is obsolete since Qt v5.8. It is replaced by setSecsSinceEpoch()
see https://doc.qt.io/archives/qt-5.8/qdatetime-obsolete.html#setTime_t

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham created this revision.Sat, Apr 20, 6:38 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Apr 20, 6:38 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
shubham requested review of this revision.Sat, Apr 20, 6:38 AM
shubham edited the summary of this revision. (Show Details)Sat, Apr 20, 6:40 AM
meven accepted this revision.Sat, Apr 20, 7:55 AM
meven added a subscriber: meven.

I don't why src/Messages.sh would need to be updated.
But the fix seems fine to me.

This revision is now accepted and ready to land.Sat, Apr 20, 7:55 AM
elvisangelaccio requested changes to this revision.Sat, Apr 20, 10:46 AM
elvisangelaccio added a subscriber: elvisangelaccio.

Please revert the mode change to Messages.sh

This revision now requires changes to proceed.Sat, Apr 20, 10:46 AM
shubham updated this revision to Diff 56627.Sat, Apr 20, 1:49 PM

Fix unintentional mode change

elvisangelaccio resigned from this revision.Sat, Apr 20, 1:57 PM
This revision is now accepted and ready to land.Sat, Apr 20, 1:57 PM
This revision was automatically updated to reflect the committed changes.

How about issuing a minor release?