Fix fullscreen mode on Windows with OpenGL

Authored by alvinhochun on Apr 18 2019, 10:49 AM.



A previous attempt was made in D1977[1] but it didn't work properly. The patch 0003-Hack-for-fullscreen-workaround.patch only partly hid the issue and the issue has resurfaced since this patch was removed.

This commit actually enables Qt's workaround with an additional patch from Qt 5.13 [2]. The workaround adds a 1px border around the window. An additional hack is added to hide three of the borders, though we can't hide all four borders since the bug will return. This currently leaves the bottom border visible as a compromise.

This workaround is not active when ANGLE is being used. If anyone is annoyed by the 1px border, they should consider switching to ANGLE.


Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
alvinhochun requested review of this revision.Apr 18 2019, 10:49 AM
alvinhochun created this revision.
alvinhochun planned changes to this revision.Apr 18 2019, 10:52 AM
alvinhochun edited the summary of this revision. (Show Details)
alvinhochun edited the summary of this revision. (Show Details)Apr 18 2019, 12:09 PM

Upload the correct patch

dkazakov accepted this revision.Apr 18 2019, 12:24 PM
dkazakov added a subscriber: dkazakov.

The patch looks perfectly fine, please push! :)

This revision is now accepted and ready to land.Apr 18 2019, 12:24 PM
This revision was automatically updated to reflect the committed changes.