Restore fullscreen on Windows

Authored by abrahams on Jun 22 2016, 7:20 PM.



There's a bunch of finger pointing with Qt saying Windows' OpenGL
implementation is broken. There is a workaround added in Qt 5.6.

Fullscreen on Windows will then add a 1px border to Qt by default. This
can be fixed by patching Qt.

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 4679.Jun 22 2016, 7:20 PM
abrahams retitled this revision from to Restore fullscreen on Windows.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: Krita.

I noticed we've been adding patches to the Krita repository. I'm not sure how to test such changes since I'm still using Emerge but I could upload the patch to Phabricator here.

This would also bump the minimum Qt version for building on Windows to 5.6.

rempt added a subscriber: rempt.Jun 22 2016, 7:46 PM

5.6 as minimum for Qt is fine; all I need to do is port the patch to mxe and check what happens then -- you can add the patch to the 3rdparty/ext_qt directory, together with the other patches.

rempt added inline comments.Jun 22 2016, 7:48 PM

This will break when cross-compiling, I'm afraid, because of the \ vs /

abrahams updated this revision to Diff 4681.Jun 22 2016, 10:14 PM

Add Qt patch for fullscreen without 1px border, write path with forward slash, bump Qt version

rempt accepted this revision.Jun 23 2016, 7:11 AM
rempt added a reviewer: rempt.

Should be fine now!

This revision is now accepted and ready to land.Jun 23 2016, 7:11 AM
This revision was automatically updated to reflect the committed changes.
abrahams marked an inline comment as done.