I noticed we've been adding patches to the Krita repository. I'm not sure how to test such changes since I'm still using Emerge but I could upload the patch to Phabricator here.

This would also bump the minimum Qt version for building on Windows to 5.6.

5.6 as minimum for Qt is fine; all I need to do is port the patch to mxe and check what happens then -- you can add the patch to the 3rdparty/ext_qt directory, together with the other patches.

rempt added inline comments.Jun 22 2016, 7:48 PM

libs/ui/KisMainWindow.cpp
141	This will break when cross-compiling, I'm afraid, because of the \ vs /

Add Qt patch for fullscreen without 1px border, write path with forward slash, bump Qt version

Should be fine now!

This revision is now accepted and ready to land.Jun 23 2016, 7:11 AM

Closed by commit R37:ac2d5a06f6c9: Restore fullscreen on Windows (authored by abrahams). · Explain WhyJun 23 2016, 2:56 PM

This revision was automatically updated to reflect the committed changes.

abrahams marked an inline comment as done.

alvinhochun mentioned this in D20657: Fix fullscreen mode on Windows with OpenGL.Apr 18 2019, 10:49 AM

alvinhochun mentioned this in R37:e83e87794bdd: Fix fullscreen mode on Windows with OpenGL.Apr 18 2019, 12:33 PM

Revision Contents
Changeset List

		Path
A	M	3rdparty/ext_qt/0003-Hack-for-fullscreen-workaround.patch (26 lines)
M		3rdparty/ext_qt/CMakeLists.txt (1 line)
M		CMakeLists.txt (7 lines)
M		libs/ui/KisMainWindow.cpp (18 lines)
M		libs/ui/KisViewManager.cpp (4 lines)
M		libs/ui/dialogs/kis_dlg_preferences.cc (3 lines)
M		libs/ui/kis_config.cc (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4679	f52db29		Jun 22 2016, 7:20 PM	★	★
Diff 2	4681	f52db29	Add Qt patch for fullscreen without 1px border, write path with forward slash, bump Qt version	Jun 22 2016, 10:14 PM	★	★
Diff 3	4686	7625539	rKRITAac2d5a06f6c94b6e1de279a9304370a19125035e	Jun 23 2016, 2:56 PM	★	★