Differential D20657

Fix fullscreen mode on Windows with OpenGL
ClosedPublic
Actions

Authored by alvinhochun on Apr 18 2019, 10:49 AM.

Details

Reviewers

dkazakov

Group Reviewers

Krita

Commits

R37:e83e87794bdd: Fix fullscreen mode on Windows with OpenGL

Summary

A previous attempt was made in D1977[1] but it didn't work properly. The patch 0003-Hack-for-fullscreen-workaround.patch only partly hid the issue and the issue has resurfaced since this patch was removed.

This commit actually enables Qt's workaround with an additional patch from Qt 5.13 [2]. The workaround adds a 1px border around the window. An additional hack is added to hide three of the borders, though we can't hide all four borders since the bug will return. This currently leaves the bottom border visible as a compromise.

This workaround is not active when ANGLE is being used. If anyone is annoyed by the 1px border, they should consider switching to ANGLE.

[1]: https://phabricator.kde.org/D1977
[2]: https://codereview.qt-project.org/246155

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

alvinhochun requested review of this revision.Apr 18 2019, 10:49 AM

alvinhochun created this revision.

alvinhochun planned changes to this revision.Apr 18 2019, 10:52 AM

alvinhochun updated this revision to Diff 56508.Apr 18 2019, 11:07 AM

alvinhochun edited the summary of this revision. (Show Details)

alvinhochun edited the summary of this revision. (Show Details)Apr 18 2019, 12:09 PM

Upload the correct patch

The patch looks perfectly fine, please push! :)

This revision is now accepted and ready to land.Apr 18 2019, 12:24 PM

Closed by commit R37:e83e87794bdd: Fix fullscreen mode on Windows with OpenGL (authored by alvinhochun). · Explain WhyApr 18 2019, 12:33 PM

This revision was automatically updated to reflect the committed changes.

alvinhochun added a commit: R37:012d64083350: Fix patch for Windows fullscreen mode hack.Apr 18 2019, 5:05 PM

Revision Contents
Changeset List

		Path
M		3rdparty/ext_qt/CMakeLists.txt (4 lines)
A	M	3rdparty/ext_qt/remove-fullscreen-border-hack.patch (38 lines)
A	M	3rdparty/ext_qt/set-has-border-in-full-screen-default.patch (162 lines)
M		CMakeLists.txt (12 lines)
A	M	config-set-has-border-in-full-screen-default.h.in (4 lines)
M		krita/main.cc (10 lines)
M		libs/ui/KisMainWindow.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56506			Apr 18 2019, 10:44 AM	★	★
Diff 2	56508			Apr 18 2019, 11:04 AM	★	★
Diff 3	56513			Apr 18 2019, 12:21 PM	★	★
Diff 4	56516	24479fd	R37:e83e87794bddd21c3bbd08ba148f17b4d2ac1456	Apr 18 2019, 12:24 PM	★	★