Differential D2059

Merge signal connections for AbstractClient in Workspace
ClosedPublic
Actions

Authored by graesslin on Jul 1 2016, 2:06 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:445335ba5f33: Merge signal connections for AbstractClient in Workspace

Summary

Have one dedicated method which performs the connection for both
Client and ShellClient. This fixes the desktopPresenceChanged signal
not being passed to the effects.

Note that not all signals are merged. Most signals setup for Client
don't make sense for ShellClient as ShellClient cannot block composite
or unredirect.

Test Plan

Test case added for ShellClient to ensure that the signal
is correctly invoked on the ShellClient, Workspace and EffectsHandler.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 4888.Jul 1 2016, 2:06 PM

graesslin retitled this revision from to Merge signal connections for AbstractClient in Workspace.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 1 2016, 2:06 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D2083: Use hiddenInternal() for a ShellClient which got unmapped.Jul 4 2016, 1:36 PM

LGTM :)

This revision is now accepted and ready to land.Jul 12 2016, 9:13 PM

Closed by commit R108:445335ba5f33: Merge signal connections for AbstractClient in Workspace (authored by graesslin). · Explain WhyJul 13 2016, 8:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/shell_client_test.cpp (38 lines)
M			wayland_server.cpp (3 lines)
M			workspace.h (1 line)
M			workspace.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4888	7610ff4		Jul 1 2016, 2:06 PM	★	★
Diff 2	5115	f9725a6	rKWIN445335ba5f3305ed71de5753061124fc7823b406	Jul 13 2016, 8:44 AM	★	★

Status	Author	Revision
Closed	graesslin	D2085 [effects] Adjust SlidingPopups to new windowShown and windowHidden signals
Closed	graesslin	D2084 [libkwineffects] Add signals windowShown and windowHidden to EffectsHandler
Closed	graesslin	D2083 Use hiddenInternal() for a ShellClient which got unmapped
Closed	graesslin	D2059 Merge signal connections for AbstractClient in Workspace