Differential D20529

add license to python test files
ClosedPublic
Actions

Authored by astippich on Apr 14 2019, 9:19 AM.

Details

Reviewers
bruns
Commits
R286:eb9b1ef9b30d: add license to python test files
Summary

silence EBN

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Apr 14 2019, 9:19 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 14 2019, 9:19 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Apr 14 2019, 9:19 AM
bruns added a subscriber: bcooksley.Apr 14 2019, 1:28 PM

@bcooksley - these tests currently fail to run under Windows: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5 WindowsMSVCQt5.11/149/testReport

"C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5 WindowsMSVCQt5.11/build/autotests/../autotests/samplefiles/testexternalextractor/main.py" failed to start: "Process failed to start: Unknown error 0x000000c1."

Apparently the python installation is "incomplete". I see two possible options, either install the missing python parts, or just disable the test on Windows. As the test is not really crucial, I would be fine with the second option.

bruns accepted this revision.Apr 14 2019, 1:57 PM
This revision is now accepted and ready to land.Apr 14 2019, 1:57 PM
bcooksley added a comment.Apr 16 2019, 10:21 AM

The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python)

I'd therefore suggest that something isn't entirely right with how Python is being executed by the tests here... can we get the full command it's running?

Closed by commit R286:eb9b1ef9b30d: add license to python test files (authored by astippich). · Explain WhyApr 16 2019, 5:45 PM
This revision was automatically updated to reflect the committed changes.
bruns added a comment.Apr 16 2019, 11:25 PM
In D20529#451147, @bcooksley wrote:

The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python)

I'd therefore suggest that something isn't entirely right with how Python is being executed by the tests here... can we get the full command it's running?

Honestly, I don't care why it fails, or if it works at all. I also have neither time nor means to debug this.

Windows - I will give this a timeframe of one month to get this fixed. If nothing has been submitted till then, I will disable the test for windows.

bruns added a comment.Apr 16 2019, 11:29 PM
In D20529#451147, @bcooksley wrote:

can we get the full command it's running?

ctest -V -R externalextractortest

bcooksley added a comment.Apr 17 2019, 6:51 AM
In D20529#451561, @bruns wrote:
In D20529#451147, @bcooksley wrote:

can we get the full command it's running?

ctest -V -R externalextractortest

That might be how the test is started, but how does it invoke Python?

bruns added a comment.Apr 17 2019, 8:15 PM
In D20529#451614, @bcooksley wrote:
In D20529#451561, @bruns wrote:
In D20529#451147, @bcooksley wrote:

can we get the full command it's running?

ctest -V -R externalextractortest

That might be how the test is started, but how does it invoke Python?

Run the command I gave, and it will tell you.

And let me quote myself:

I also have neither time nor means to debug this.

Revision Contents
Changeset List

Diff 56383

View Options

autotests/samplefiles/testexternalextractor/main.py

Loading...
View Options

autotests/samplefiles/testexternalwriter/main.py

Loading...