Currently, KFileMetaData stores multi-values (e.g. multiple arists)
as multiple entries in the property map, while Baloo combines them to List
before serialization. More information in D19087 (your opinion is also appreciated there!)
or T8196.
Consider both cases such that the metadata retrieved by the baloo indexer and the file
indexer is the same.
Details
Details
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I will have a look thanks.
I will also have a look at your other suggestions.
I hope to be able to do it this week-end if time permits.
| src/filescanner.cpp | ||
|---|---|---|
| 119 | There is a typo in the variable name | |
| 258 | I am afraid that for most cases the concerned properties will be single valued and this code path will be slower than previous code. | |
Comment Actions
I am missing time to investigate deep enough in KFileMetaData and Baloo but if D20526 lands, why this diff would still be needed ?
Comment Actions
It will become less relevant as there will be less lists inserted, but still possible. Vorbis comments explicitly allows to insert multiple tags so there is a chance that there will be multiple entries in the map extracted from KFileMetadata, or lists when obtained via Baloo.
Also note that all existing data in the baloo database is currently not updated when extractors change.
Comment Actions
OK, thanks for the explanations.
Also note that all existing data in the baloo database is currently not updated when extractors change.
Yes I know that. I vaguely remember some work going into that direction (I was talking about D19109).
In the future, Elisa will need to make good use of that.