Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset
ClosedPublic

Authored by kossebau on Apr 12 2019, 3:51 PM.

Details

Summary

The hands of the clocks still relied on the KDE4 times rule that the
position in y-axis relativ to the clock center would define the relative
rotation point for the hands.

With the default in Plasma 5 being (width/2, width/2) from topleft of the
hand shape, using hints of upcoming Plasma 5.16 allows to override that
again to match the original definition, without the need to enlarge
the pixmaps of the hand shapes.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
fixairclock
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10773
Build 10791: arc lint + arc unit
kossebau created this revision.Apr 12 2019, 3:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 12 2019, 3:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 12 2019, 3:51 PM

Looks like this with Plasma 5.16:


which gets us again to what it looked originally, cmp. https://kde.org/announcements/4.3/images/kde430-desktop.png

kossebau updated this revision to Diff 56077.Apr 12 2019, 4:05 PM

Oxygen clock has the same issue

kossebau retitled this revision from Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset to Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset.Apr 12 2019, 4:06 PM
kossebau edited the summary of this revision. (Show Details)
ngraham accepted this revision.Apr 12 2019, 5:20 PM
This revision is now accepted and ready to land.Apr 12 2019, 5:20 PM
This revision was automatically updated to reflect the committed changes.