KateIconBorder: Fix folding popup width and height
ClosedPublic

Authored by loh.tar on Apr 12 2019, 2:50 PM.

Details

Summary
  • Now take the popup the whole width of the view instead of the half
  • The height computation is fixed to use all possible space left and allow slightly overpainting of the view bottom to cover all lines properly

I hope the latter point cause no distaste.
When other lines are still visible is that for me always confusing.
There is a patch left which fix the not correct end of the folding range,
where the closing brace is not covered. (No pic sorry)
Works for the preview nicely but cause trouble while perform the fold,
so need some more work/ideas...

Test Plan

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Apr 12 2019, 2:50 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptApr 12 2019, 2:50 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Apr 12 2019, 2:50 PM
cullmann accepted this revision.Apr 14 2019, 12:34 PM
cullmann added a subscriber: cullmann.

Works ok for me.

This revision is now accepted and ready to land.Apr 14 2019, 12:34 PM
This revision was automatically updated to reflect the committed changes.