KateIconBorder: Fix folding popup width and height

Authored by cullmann on Apr 14 2019, 12:32 PM.

Description

KateIconBorder: Fix folding popup width and height

Summary:

  • Now take the popup the whole width of the view instead of the half
  • The height computation is fixed to use all possible space left and allow slightly overpainting of the view bottom to cover all lines properly

I hope the latter point cause no distaste.
When other lines are still visible is that for me always confusing.
There is a patch left which fix the not correct end of the folding range,
where the closing brace is not covered. (No pic sorry)
Works for the preview nicely but cause trouble while perform the fold,
so need some more work/ideas...

Test Plan:

Reviewers: KTextEditor, cullmann

Reviewed By: KTextEditor, cullmann

Subscribers: cullmann, kwrite-devel, kde-frameworks-devel, KTextEditor

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D20495

Details

Committed
cullmannApr 14 2019, 12:34 PM
Reviewer
KTextEditor
Differential Revision
D20495: KateIconBorder: Fix folding popup width and height
Parents
R39:a9f97f1be115: avoid view jump to bottom on folding changes
Branches
Unknown
Tags
Unknown

Hmm, arc land didn't use the proper author :/
Guess I need to check that in the future more properly.