Differential D20484

Mark archive and directory as const
ClosedPublic
Actions

Authored by aacid on Apr 12 2019, 8:03 AM.

Details

Reviewers
apol
Commits
R301:808e4463afb1: Mark archive and directory as const
Summary

Makes clear we don't want to modify them

Diff Detail

Repository
R301 KEmoticons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Apr 12 2019, 8:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 12 2019, 8:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Apr 12 2019, 8:03 AM
apol accepted this revision.Apr 12 2019, 11:04 AM
apol added a subscriber: apol.

The patch is fine, I wonder how you ended up deciding this was a change to be done. :P

This revision is now accepted and ready to land.Apr 12 2019, 11:04 AM
Closed by commit R301:808e4463afb1: Mark archive and directory as const (authored by aacid). · Explain WhyApr 12 2019, 12:41 PM
This revision was automatically updated to reflect the committed changes.
aacid added a comment.Apr 12 2019, 12:41 PM
In D20484#448629, @apol wrote:

The patch is fine, I wonder how you ended up deciding this was a change to be done. :P

That's coming up next ;)

Revision Contents
Changeset List

PathPackages
Msrc/core/kemoticons.cpp (8 lines)

Diff 56062

View Options

src/core/kemoticons.cpp

Loading...