Differential D20457

[balooctl] clear command: Remove bogus check for documentData, cleanup
ClosedPublic
Actions

Authored by bruns on Apr 11 2019, 12:54 AM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Frameworks
Commits
R293:ceb9b3756106: [balooctl] clear command: Remove bogus check for documentData, cleanup
Summary

In case only BasicIndexing is enabled, or when the content indexing
is suspended due to "onBattery" mode, no data is added to the document.

There is no reason to disallow clearing a file which has no data.

Also remove an unused Indexer instance.

Test Plan

create a file with contentIndexing disabled
try to remove it from the index with balooctl clear <file>

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 11 2019, 12:54 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 11 2019, 12:54 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 11 2019, 12:54 AM
ngraham accepted this revision.Apr 11 2019, 12:58 AM
This revision is now accepted and ready to land.Apr 11 2019, 12:58 AM
Closed by commit R293:ceb9b3756106: [balooctl] clear command: Remove bogus check for documentData, cleanup (authored by bruns). · Explain WhyApr 11 2019, 1:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tools/balooctl/main.cpp (5 lines)

Diff 55953

View Options

src/tools/balooctl/main.cpp

Loading...