Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R111 KSysguard Library
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10708 Build 10726: arc lint + arc unit
Comment Actions
Hi, thanks for the review.
I know about the issues, I've uploaded the patch to avoid losing it :)
signalplotter/ksignalplotter.cpp | ||
---|---|---|
896–898 | Could you please explain why we have to do this? |
signalplotter/ksignalplotter.cpp | ||
---|---|---|
896–898 | To avoid artifacts when painting beams. |
Comment Actions
To avoid artifacts when painting beams.
It might avoid it, but it doesn't explain why it makes sense.
setWidth should be in logical sizes. It gets affected by the view transform.
Comment Actions
Beams look ugly when their width is >= 4 pixels.
The idea is to draw them with the same width regardless of DPI.
Another option is to not set Qt::FlatCap for thick pens, but I prefer this one.