Differential D20420

[Folder View] use Math.floor() instead of Math.round()
ClosedPublic
Actions

Authored by ngraham on Apr 9 2019, 9:55 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:b5d0043c33db: [Folder View] use Math.floor() instead of Math.round()
Summary

This is more technically correct and doesn't leave any empty space on the right side
of the screen.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
floor-rather-than-rounding (branched from Plasma/5.12)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10680
Build 10698: arc lint + arc unit
ngraham created this revision.Apr 9 2019, 9:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2019, 9:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 9 2019, 9:55 PM
hein accepted this revision.Apr 9 2019, 9:56 PM
This revision is now accepted and ready to land.Apr 9 2019, 9:56 PM
Closed by commit R119:b5d0043c33db: [Folder View] use Math.floor() instead of Math.round() (authored by ngraham). · Explain WhyApr 9 2019, 10:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55863

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...