Differential D20394

With Qt >= 5.10.0 use QSortFilterProxyModel instead of KRecursiveFilterProxyModel
ClosedPublic
Actions

Authored by ahmadsamir on Apr 8 2019, 8:31 PM.

Details

Reviewers
cullmann
dhaumann
Group Reviewers
Kate
Commits
R40:45b99aa2c3ac: With Qt >= 5.10.0 use QSortFilterProxyModel instead of…
Summary

QSortFilterProxyModel in Qt >= 5.10.0 can recurse when showing
filetering results, thus use it directly.

Test Plan

Filtering with a string in the Projects panel shows all the matching
results including ones from any directories in the tree view.

Diff Detail

Repository
R40 Kate
Branch
krecursiveproxymodel-deprecate (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10637
Build 10655: arc lint + arc unit
ahmadsamir created this revision.Apr 8 2019, 8:31 PM
Restricted Application added a project: Kate. · View Herald TranscriptApr 8 2019, 8:31 PM
ahmadsamir requested review of this revision.Apr 8 2019, 8:31 PM
dhaumann accepted this revision.Apr 9 2019, 8:15 AM

Well, if that works, I don't see an issue with this.

This revision is now accepted and ready to land.Apr 9 2019, 8:15 AM
ahmadsamir added a comment.Apr 9 2019, 12:16 PM

Please commit. Thanks.

Closed by commit R40:45b99aa2c3ac: With Qt >= 5.10.0 use QSortFilterProxyModel instead of… (authored by ahmadsamir, committed by cullmann). · Explain WhyApr 12 2019, 7:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55778

View Options

addons/project/kateprojectviewtree.cpp

Loading...