Differential D20328

[balooshow] Do not print a bogus warning for a non-indexed file
ClosedPublic
Actions

Authored by bruns on Apr 6 2019, 10:07 PM.

Details

Reviewers

ngraham
astippich
poboiko

Group Reviewers

Baloo
Frameworks

Commits

R293:e05514aa6469: [balooshow] Do not print a bogus warning for a non-indexed file

Summary

balooshow allows to query file information by document id, e.g.
balooshow 12345678. In case the file is not indexed,
Transaction::documentUrl(fid) returns an empty url, and the lookup
Baloo::filePathToId("") returns 0. Don't print a misleading warning,
just state the file is not indexed.

Test Plan

balooshow <unindexed-file-id>

Diff Detail

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bruns created this revision.Apr 6 2019, 10:07 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 6 2019, 10:07 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Apr 6 2019, 10:07 PM

Harbormaster completed remote builds in B10543: Diff 55608.Apr 6 2019, 10:07 PM

ngraham added inline comments.Apr 6 2019, 10:58 PM

src/tools/balooshow/main.cpp
142	Why were all these spaces after the colons removed?

readd erroneously removed spaces

Harbormaster completed remote builds in B10590: Diff 55694.Apr 7 2019, 5:01 PM

bruns added inline comments.Apr 7 2019, 6:09 PM

src/tools/balooshow/main.cpp
142	confused this with a debug stream ...

bruns marked an inline comment as done.Apr 7 2019, 6:09 PM

only one minor nitpick

src/tools/balooshow/main.cpp
136	Also add a space here after "Url:"?

This revision is now accepted and ready to land.Apr 7 2019, 6:40 PM

bruns added inline comments.Apr 7 2019, 6:41 PM

src/tools/balooshow/main.cpp
136	Yes, will add it.

Closed by commit R293:e05514aa6469: [balooshow] Do not print a bogus warning for a non-indexed file (authored by bruns). · Explain WhyApr 7 2019, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/tools/balooshow/main.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55608	0835a56		Apr 6 2019, 10:07 PM	★	★
Diff 2	55694	765b4c7	readd erroneously removed spaces	Apr 7 2019, 5:01 PM	★	★
Diff 3	55702	d49bb53	R293:e05514aa646983dd2885b7ea18e993fa2613f4a2	Apr 7 2019, 6:43 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
42d3ff6a1c67	f22f0a6735d7	765b4c7cccbe	Stefan Brüns	[balooshow] Do not print a bogus warning for a non-indexed file (Show More…)	Apr 6 2019, 10:06 PM

Diff 55702

View Options

src/tools/balooshow/main.cpp