Differential D2029

[Task Manager Backend] Honor "NotShowIn" and "OnlyShowIn" for Jump List Actions
ClosedPublic
Actions

Authored by broulik on Jun 28 2016, 9:34 AM.

Details

Reviewers
hein
dfaure
Group Reviewers
Plasma
Commits
R119:4524bd925633: [Task Manager Backend] Honor "NotShowIn" and "OnlyShowIn" for Jump List Actions
Summary

This allows applications to explicitly filter out or only show actions in "KDE".

Test Plan

We now need to patch/report bugs against a gazillion apps that needlessly restrict jump list actions to only Unity, such as Cantata, Firefox, Thunderbird, Steam, ...

Might also be that Ubuntu distribution packages I'm using for Firefox et al have those actions added downstream rather than by the original app author in which case we need to complain to Ubuntu and urge upstreams to ship actions.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4789.Jun 28 2016, 9:34 AM
broulik retitled this revision from to [Task Manager Backend] Honor "NotShowIn" for Jump List Actions.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein, dfaure.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2016, 9:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure edited edge metadata.Jun 28 2016, 9:42 AM

Oh boy we're heading right into a mess similar to web sites and web browsers, if we continue this way. Next we'll need a "really only show in Unity", then we'll start making special cases for some apps, and then ... the world will implode.

I am very much against ignoring OnlyShowIn.
Do implement OnlyShowIn too, then do complain to those people wrongly setting it to Unity. *That* is the right thing to do.

broulik updated this revision to Diff 4792.Jun 28 2016, 9:56 AM
broulik retitled this revision from [Task Manager Backend] Honor "NotShowIn" for Jump List Actions to [Task Manager Backend] Honor "NotShowIn" and "OnlyShowIn" for Jump List Actions.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik edited edge metadata.
broulik edited the test plan for this revision. (Show Details)
dfaure accepted this revision.Jun 28 2016, 10:46 AM
dfaure edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jun 28 2016, 10:46 AM
Closed by commit R119:4524bd925633: [Task Manager Backend] Honor "NotShowIn" and "OnlyShowIn" for Jump List Actions (authored by broulik). · Explain WhySep 12 2016, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6654

View Options

applets/taskmanager/plugin/backend.cpp

Loading...