Differential D20267

Add HiDPI support for thumbnails
ClosedPublic
Actions

Authored by volkov on Apr 5 2019, 1:46 PM.

Details

Reviewers

ngraham

Group Reviewers

Gwenview

Commits

R260:968c411a9957: Add HiDPI support for thumbnails

Summary

The idea is to localize changes in ThumbnailView as much as possible:
ThumbnailView::thumbnailSize() returns the size in device independent
pixels, i.e. it seems from the outside that ThumbnailView behaves as
well as before this change. But, of course, item delegates must take
into account that ThumbnailView::thumbnailForIndex() will return
a pixmap with the devicePixelRatio set.

CCBUG: 373178

Diff Detail

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

volkov created this revision.Apr 5 2019, 1:46 PM

Restricted Application added a project: Gwenview. · View Herald TranscriptApr 5 2019, 1:46 PM

volkov requested review of this revision.Apr 5 2019, 1:46 PM

Harbormaster completed remote builds in B10463: Diff 55474.Apr 5 2019, 1:46 PM

volkov added a reviewer: Gwenview.Apr 5 2019, 1:47 PM

volkov mentioned this in D9078: HiDPI fixes for thumbnails in gwenview.

Thanks for the patch!

I notice that in full screen mode, the thumbnails in the thumbnail bar sometimes become too large after clicking on individual ones:

(they also all have the same aspect ratio, but that's a pre-existing bug)

fixed

Harbormaster completed remote builds in B10475: Diff 55496.Apr 5 2019, 6:59 PM

ngraham edited the summary of this revision. (Show Details)Apr 5 2019, 8:28 PM

Thanks, this looks perfect now.

This revision is now accepted and ready to land.Apr 5 2019, 8:34 PM

small fixes

Harbormaster completed remote builds in B10503: Diff 55533.Apr 6 2019, 9:34 AM

ngraham accepted this revision.Apr 7 2019, 2:01 PM

Closed by commit R260:968c411a9957: Add HiDPI support for thumbnails (authored by volkov, committed by ngraham). · Explain WhyApr 7 2019, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			lib/thumbnailview/previewitemdelegate.cpp (18 lines)
M			lib/thumbnailview/thumbnailbarview.cpp (17 lines)
M			lib/thumbnailview/thumbnailslider.cpp (2 lines)
M			lib/thumbnailview/thumbnailview.cpp (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55474	97e7de5		Apr 5 2019, 1:46 PM	★	★
Diff 2	55496	97e7de5	fixed	Apr 5 2019, 6:59 PM	★	★
Diff 3	55533	97e7de5	small fixes	Apr 6 2019, 9:34 AM	★	★
Diff 4	55675	97e7de5	R260:968c411a99576aa9e7784812e26e054ab290ae27	Apr 7 2019, 2:02 PM	★	★