Add HiDPI support for thumbnails
ClosedPublic

Authored by volkov on Apr 5 2019, 1:46 PM.

Details

Summary

The idea is to localize changes in ThumbnailView as much as possible:
ThumbnailView::thumbnailSize() returns the size in device independent
pixels, i.e. it seems from the outside that ThumbnailView behaves as
well as before this change. But, of course, item delegates must take
into account that ThumbnailView::thumbnailForIndex() will return
a pixmap with the devicePixelRatio set.

CCBUG: 373178

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volkov created this revision.Apr 5 2019, 1:46 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptApr 5 2019, 1:46 PM
volkov requested review of this revision.Apr 5 2019, 1:46 PM
ngraham added a subscriber: ngraham.Apr 5 2019, 3:36 PM

Thanks for the patch!

I notice that in full screen mode, the thumbnails in the thumbnail bar sometimes become too large after clicking on individual ones:

(they also all have the same aspect ratio, but that's a pre-existing bug)

ngraham edited the summary of this revision. (Show Details)Apr 5 2019, 8:28 PM
ngraham accepted this revision.Apr 5 2019, 8:34 PM

Thanks, this looks perfect now.

This revision is now accepted and ready to land.Apr 5 2019, 8:34 PM
volkov updated this revision to Diff 55533.Apr 6 2019, 9:34 AM

small fixes

ngraham accepted this revision.Apr 7 2019, 2:01 PM
This revision was automatically updated to reflect the committed changes.