Differential D20221

AppArmor: don't highlight variable assignments and alias rules within profiles
ClosedPublic
Actions

Authored by nibags on Apr 3 2019, 6:15 AM.

Details

Reviewers
dhaumann
cullmann
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:1726c4f868f6: AppArmor: don't highlight variable assignments and alias rules within profiles
Summary

Depends on D20220

There are some minor changes to the AppArmor highlighter.

Changes:

  • Don't highlight variable assignments and alias rules inside profiles.
  • Add new keywords of "tunables/share" variables.
  • Change style of "Other Option" attribute.

Diff Detail

Repository
R216 Syntax Highlighting
Branch
arcpatch-D20221
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10418
Build 10436: arc lint + arc unit
nibags requested review of this revision.Apr 3 2019, 6:15 AM
nibags created this revision.
nibags updated this revision to Diff 55367.Apr 3 2019, 8:42 PM
  • Remove "alias" in the "_end_rule" context and add some comments
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptApr 3 2019, 8:42 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags updated this revision to Diff 55368.Apr 3 2019, 8:52 PM
  • Fix some indentations
  • Remove selinux-*.xml changes
nibags updated this revision to Diff 55378.Apr 3 2019, 9:29 PM
  • Apply changes in apparmor.xml, remove selinux-*.xml changes
nibags updated this revision to Diff 55382.Apr 3 2019, 9:55 PM
  • Update tests
nibags updated this revision to Diff 55457.Apr 5 2019, 8:19 AM
  • Don't highlight as Error the "alias" keyword within rules

Better not to highlight anything in rules.

cullmann accepted this revision.Apr 7 2019, 1:18 PM

See no obvious issues, please commit, thanks!

This revision is now accepted and ready to land.Apr 7 2019, 1:18 PM
Closed by commit R216:1726c4f868f6: AppArmor: don't highlight variable assignments and alias rules within profiles (authored by nibags, committed by cullmann). · Explain WhyApr 12 2019, 7:39 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mdata/syntax/selinux-cil.xml (1256 lines)
Mdata/syntax/selinux-fc.xml (485 lines)

Diff 55378

View Options

data/syntax/selinux-cil.xml

Loading...
View Options

data/syntax/selinux-fc.xml

Loading...