Implement the keystate protocol
ClosedPublic

Authored by apol on Apr 1 2019, 11:53 PM.

Details

Summary

Depends on D20191

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint SkippedExcuse: no cppcheck
Unit
No Unit Test Coverage
Build Status
Buildable 10353
Build 10371: arc lint + arc unit
apol created this revision.Apr 1 2019, 11:53 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 1 2019, 11:53 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Apr 1 2019, 11:53 PM

Sorry, but I don't see the need for this protocol as that is already part of wl_keyboard.

davidedmundson accepted this revision.Jun 20 2019, 2:32 PM
davidedmundson added a subscriber: davidedmundson.

Sorry, but I don't see the need for this protocol as that is already part of wl_keyboard.

It isn't really.

You still need a protocol to tell you to send wl_keyboard events outside of the normal focus handling. If you require a custom protocol (and custom code) to tell you how to abuse an existing protocol we may as well just do the simple protocol in the first place. It'll be more extensible.

This revision is now accepted and ready to land.Jun 20 2019, 2:32 PM
This revision was automatically updated to reflect the committed changes.