I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.

In D20170#469080, @hindenburg wrote:

I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.

Yeah, agreed. I'm just waiting for the Interface Api to be finished until I update this. Just opened this to have some kind of reference of how the implementation might look like and also for testing purpose.

Can you update this patch assuming that frameworks 5.60 will have the new code?

https://community.kde.org/Schedules/Frameworks

Thanks, do you have time to add some tests? They would be added to autotests/TerminalInterfaceTest.cpp TerminalInterfaceTest.h

KDE uses spaces instead of tabs. Does the tests past if you manually install the new kde_terminal_interface.h and remove the #IF? I get failures in the QVERIFY(terminal).

If you effectively compile with the InterfaceV2 enabled and an updated kde_terminal_interface.h it should pass. Only issue I had is that the tests don't load the konsolepart.so from the build dir directly which means the actually loaded konsolepart.so is still the old version. This results in the test failure.