Actually make the network list view show up
Needs ReviewPublic

Authored by vkrause on Mar 30 2019, 9:31 PM.

Details

Reviewers
jgrulich

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10276
Build 10294: arc lint + arc unit
vkrause created this revision.Mar 30 2019, 9:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2019, 9:31 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vkrause requested review of this revision.Mar 30 2019, 9:31 PM
jgrulich added a subscriber: mart.Mar 31 2019, 5:24 PM

Hmm, I would say it should work even without your change, to me setting the view to fill the parent is correct. Can anyone else confirm this issue? Marco @mart ?

With that the network list had 0 width and was thus invisible for me, both on desktop and on yocto/rpi, using Qt 5.11 and latest Kirigami.

I cannot confirm, if I run "kcmshell5 wifisettings" it works just fine. I'm now on Qt 5.12, but I'm pretty sure it worked even before. Let's wait if someone else can confirm this.

Maybe that's the relevant difference already, I have only been testing within plasma-settings, need to retest with kcmshell directly.

It works for me even in plasma-settings.

Can we drop this request? I believe it works just fine now.

Is this still relevant?