Differential D20114

Remove Q_FOREACH from inlined header functions
ClosedPublic
Actions

Authored by dvratil on Mar 29 2019, 12:44 PM.

Details

Reviewers
sitter
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
R487:8a92f185c76d: Remove Q_FOREACH from inlined header functions
Summary

Allows applications that want to compile with -DQT_NO_FOREACH to
build against Phonon.

Diff Detail

Repository
R487 Phonon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Mar 29 2019, 12:44 PM
Owners added a reviewer: Restricted Owners Package.Mar 29 2019, 12:44 PM
dvratil requested review of this revision.Mar 29 2019, 12:44 PM
sitter accepted this revision.Mar 29 2019, 12:49 PM

Do we want this released pronto?

This revision is now accepted and ready to land.Mar 29 2019, 12:49 PM
dvratil added a comment.Mar 31 2019, 9:27 AM

We worked-around this in the one PIM module that was affected, so I don't think there's a big hurry to get this out.

Closed by commit R487:8a92f185c76d: Remove Q_FOREACH from inlined header functions (authored by dvratil). · Explain WhyMar 31 2019, 9:31 AM
This revision was automatically updated to reflect the committed changes.
rikmills added a subscriber: rikmills.Apr 26 2019, 8:39 AM

Neon CI build

02:09:16 /workspace/build/phonon/objectdescription.h:270:16: error: ‘propertyNames’ does not name a type
02:09:16 const auto propertyNames = d.propertyNames();

sitter added a comment.Apr 26 2019, 9:30 AM

Qt4?

... guessing Qt4 build is not c++11 or something

Revision Contents
Changeset List

PathPackages
Mphonon/objectdescription.h (3 lines)

Diff 55117

View Options

phonon/objectdescription.h

Loading...