Differential D20837

use concrete types
ClosedPublic
Actions

Authored by sitter on Apr 26 2019, 10:25 AM.

Details

Reviewers
dvratil
Commits
R487:f46b5cd505dd: use concrete types
Summary

auto may cause woes when building against qt4. not quite sure why, but
we can simply not use auto and be happy

Test Plan

builds (on qt5 anyway)

Diff Detail

Repository
R487 Phonon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Apr 26 2019, 10:25 AM
sitter created this revision.
dvratil accepted this revision.Apr 28 2019, 3:20 PM

We still support Qt4? :-O

Code in header files gets compiled with cxxflags of the compiled unit that includes them, so I assume when building a Qt4 code, the CXX standard is not set to C++11...

This revision is now accepted and ready to land.Apr 28 2019, 3:20 PM
sitter added a comment.Apr 29 2019, 8:52 AM
In D20837#457524, @dvratil wrote:

We still support Qt4? :-O

Yeah. Do you want to remove it? (:

Closed by commit R487:f46b5cd505dd: use concrete types (authored by sitter). · Explain WhyApr 29 2019, 10:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mphonon/objectdescription.h (4 lines)

Diff 57167

View Options

phonon/objectdescription.h

Loading...