Differential D20102

[timeline] Fix missing/misplaced SlaveBase::finished() calls
ClosedPublic
Actions

Authored by bruns on Mar 28 2019, 11:51 PM.

Details

Reviewers
poboiko
ngraham
astippich
Group Reviewers
Baloo
Frameworks
Commits
R293:fb3fb089c4bc: [timeline] Fix missing/misplaced SlaveBase::finished() calls
Summary

Each stat()/mimetype()/listDir() call has to be finalized with
a call to finished() after all entries where emitted.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 28 2019, 11:51 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 28 2019, 11:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 28 2019, 11:51 PM
ngraham accepted this revision.Mar 29 2019, 11:09 PM
This revision is now accepted and ready to land.Mar 29 2019, 11:09 PM
Closed by commit R293:fb3fb089c4bc: [timeline] Fix missing/misplaced SlaveBase::finished() calls (authored by bruns). · Explain WhyMar 30 2019, 1:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55052

View Options

src/kioslaves/timeline/kio_timeline.cpp

Loading...