Differential D20082

Safeguard against invalid files
ClosedPublic
Actions

Authored by astippich on Mar 27 2019, 7:58 PM.

Details

Reviewers
bruns
ngraham
Commits
R286:1ac4253f3cf0: Safeguard against invalid files
Summary

Invalid vorbis files may crash in taglib due to a dereference
on an invalid pointer. Explicitly check that the file is valid.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Mar 27 2019, 7:58 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 27 2019, 7:58 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mar 27 2019, 7:58 PM
astippich added a comment.Mar 27 2019, 7:59 PM

Seems like a good idea in general, and a patch for upstream to fix the crash was rejected.

astippich added a comment.Mar 31 2019, 11:41 AM

ping. I would like to land this for KF 5.57 to fix crashes in the taglib extractors because of invalid files once and for all.

ngraham accepted this revision.Mar 31 2019, 2:22 PM
This revision is now accepted and ready to land.Mar 31 2019, 2:22 PM
bruns accepted this revision.Mar 31 2019, 2:29 PM
Closed by commit R286:1ac4253f3cf0: Safeguard against invalid files (authored by astippich). · Explain WhyApr 2 2019, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/taglibextractor.cpp (88 lines)

Diff 55296

View Options

src/extractors/taglibextractor.cpp

Loading...