Differential D20070

[PlasmaComponents3 ComboBox] Fix textColor
ClosedPublic
Actions

Authored by broulik on Mar 26 2019, 9:01 PM.

Details

Reviewers
mart
apol
Group Reviewers
Plasma
Commits
R242:d868804a7fe4: [PlasmaComponents3 ComboBox] Fix textColor
Summary

Uses the one from ColorScope rather than Kirigami.
Kirigami.Theme isn't used in any other Plasma Components 3 and the opacity already changes for when it's disabled

Test Plan
  • ComboBox has correct color now

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 26 2019, 9:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 26 2019, 9:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mar 26 2019, 9:01 PM
apol accepted this revision.Mar 26 2019, 10:46 PM
This revision is now accepted and ready to land.Mar 26 2019, 10:46 PM
Closed by commit R242:d868804a7fe4: [PlasmaComponents3 ComboBox] Fix textColor (authored by broulik). · Explain WhyApr 1 2019, 8:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55165

View Options

src/declarativeimports/plasmacomponents3/ComboBox.qml

Loading...