Differential D20061

Avoid tiny cards on high screen resolutions
ClosedPublic
Actions

Authored by volkov on Mar 26 2019, 12:09 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Commits
R410:e41c3cce214e: Avoid tiny cards on high screen resolutions
Summary

Calculated card width can be too large. Clamp it to the
maximum value instead of falling back to the default
width of 10 pixels.

Diff Detail

Repository
R410 KPatience
Branch
Applications/19.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10147
Build 10165: arc lint + arc unit
volkov created this revision.Mar 26 2019, 12:09 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMar 26 2019, 12:09 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
volkov requested review of this revision.Mar 26 2019, 12:09 PM
heikobecker added a subscriber: heikobecker.Mar 28 2019, 6:29 PM

Can't really say anything about the maximum number, but cards are indeed not tiny anymore on my ~170 DPI display (probably rather low HiDPI)

+1

This revision was not accepted when it landed; it landed in state Needs Review.Apr 24 2019, 3:57 PM
Closed by commit R410:e41c3cce214e: Avoid tiny cards on high screen resolutions (authored by volkov). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibkcardgame/kabstractcarddeck.cpp (5 lines)

Diff 54851

View Options

libkcardgame/kabstractcarddeck.cpp

Loading...