Add "Up" action to editable mode, accessible via Key_Up press while focus is on lineEdit
AbandonedPublic

Authored by krutovmikhail on Mar 23 2019, 6:45 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
VDG
Summary

This is somewhat an implementation of:

Bug 195801 - go up in folder hierachy when in "edit mode"

Somewhat because I did it in a bit of a different way then it was discussed in the comments.

Namely: Pressing Up in editable mode puts user 1 directory up from the current location.

Diff Detail

Repository
R318 Dolphin
Branch
mkrutov/20190323/feat/edit_mode_up
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10022
Build 10040: arc lint + arc unit
krutovmikhail created this revision.Mar 23 2019, 6:45 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 23 2019, 6:45 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
krutovmikhail requested review of this revision.Mar 23 2019, 6:45 PM
ngraham added a reviewer: VDG.Mar 24 2019, 5:43 PM

Considering that right now the up arrow key does nothing at all when in editable mode, I think this makes a lot of sense. However what do you think about adding this functionality to the URL Navigator widget itself? That way clients like Dolphin wouldn't have to implement a custom behavior, and all would get it for free.

https://cgit.kde.org/kio.git/tree/src/filewidgets/kurlnavigator.cpp

Whaddaya think?

Yes please, this feature really belongs to KUrlNavigator.

krutovmikhail abandoned this revision.Mar 24 2019, 6:02 PM

Alright, I'll re-open this vs KUrlNavigator soon. Thanks!

P.s. Pretty sure I have to abandon revision & reopen new one when switching projects. If this is the case, should I add both of you to reviewers when I'll open the new revision?

Yes please. :)