Differential D19950

Move Safely Remove down in places context menu
ClosedPublic
Actions

Authored by tigrang on Mar 21 2019, 6:50 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:1eaf5d3e0362: Move Safely Remove down in places context menu
Summary

BUG: 405620

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tigrang created this revision.Mar 21 2019, 6:50 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 21 2019, 6:50 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
tigrang requested review of this revision.Mar 21 2019, 6:50 PM
ngraham requested changes to this revision.Mar 21 2019, 11:29 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! The Empty trash action should stay on top IMO.

This revision now requires changes to proceed.Mar 21 2019, 11:29 PM
tigrang updated this revision to Diff 54522.Mar 22 2019, 12:12 AM
tigrang updated this revision to Diff 54523.Mar 22 2019, 12:29 AM

I undid changes to Trash. The only difference now is Mount/Unmount is lower in the list.

elvisangelaccio added a subscriber: elvisangelaccio.Mar 23 2019, 9:55 AM
In D19950#436013, @tigrang wrote:

I undid changes to Trash. The only difference now is Mount/Unmount is lower in the list.

Could you update the commit message then? Thanks!

tigrang retitled this revision from Move Empty Trash and Safely Remove down in places context menu to Move Safely Remove down in places context menu.Mar 23 2019, 6:02 PM
tigrang edited the summary of this revision. (Show Details)
tigrang added a comment.Mar 23 2019, 6:04 PM

Does it use revision title field for the commit message?

ngraham accepted this revision.Mar 24 2019, 3:34 PM
In D19950#436868, @tigrang wrote:

Does it use revision title field for the commit message?

Yep. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

@elvisangelaccio if you approve, should this go to stable or master?

This revision is now accepted and ready to land.Mar 24 2019, 3:34 PM
elvisangelaccio accepted this revision.Mar 24 2019, 3:46 PM

Generally UI changes shouldn't go to the stable branch, but this can be considered a bugfix, so let's go with 19.04 ;)

Closed by commit R318:1eaf5d3e0362: Move Safely Remove down in places context menu (authored by tigrang, committed by ngraham). · Explain WhyMar 24 2019, 5:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/panels/places/placespanel.cpp (32 lines)

Diff 54698

View Options

src/panels/places/placespanel.cpp

Loading...