Implement logging category for rtf-qt
ClosedPublic

Authored by pvuorela on Mar 20 2019, 11:21 AM.

Details

Summary

To be noted that indentation looks a bit off, rtf-qt has a mixed bag of hard tabs and spaces, used only spaces here.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pvuorela created this revision.Mar 20 2019, 11:21 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptMar 20 2019, 11:21 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
pvuorela requested review of this revision.Mar 20 2019, 11:21 AM
danders accepted this revision.Mar 20 2019, 11:32 AM
danders added a subscriber: danders.

Strange indents, could you fix it?
Otherwise ok.

This revision is now accepted and ready to land.Mar 20 2019, 11:32 AM

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

Yes, sorry, as you say better done separatly.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Probably.

This revision was automatically updated to reflect the committed changes.