When the configuration dialog is closed with unsaved changes,
a message box is prompted to save/discard them or cancel the event.
BUG: 391206
elvisangelaccio |
Dolphin |
When the configuration dialog is closed with unsaved changes,
a message box is prompted to save/discard them or cancel the event.
BUG: 391206
No Linters Available |
No Unit Test Coverage |
Buildable 10095 | |
Build 10113: arc lint + arc unit |
I would tend to agree. "Cancel" is very much a "discard everything, I didn't mean to change stuff" action.
src/settings/dolphinsettingsdialog.cpp | ||
---|---|---|
163 ↗ | (On Diff #54395) | Please use semantic markup and replace \n with <nl/>. See https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup for more details. |
src/settings/dolphinsettingsdialog.h | ||
52 ↗ | (On Diff #54395) | QWidget::closeEvent() is protected, I'd make it protected also here. |
54 ↗ | (On Diff #54395) | There is already a private section in this class. |
src/settings/dolphinsettingsdialog.cpp | ||
---|---|---|
163 ↗ | (On Diff #54395) | And really, do we even need a line break at all here? |