Differential D19825

Improve update states' UI
ClosedPublic
Actions

Authored by ngraham on Mar 17 2019, 1:23 PM.

Details

Reviewers
apol
Group Reviewers
VDG
Discover Software Store
Commits
R134:95c39a6f7f2b: Improve update states' UI
Summary
  • Add a busy indicator when something is refreshing or checking
  • Update strings to be a bit more user-friendly
  • Don't change the Update page's title; status is adequately indicated by the footer text already

BUG: 402897
CCBUG: 396140
FIXED-IN: 5.16.0

Test Plan

For example:

Diff Detail

Repository
R134 Discover Software Store
Branch
improve-update-states (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9730
Build 9748: arc lint + arc unit
ngraham created this revision.Mar 17 2019, 1:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2019, 1:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 17 2019, 1:23 PM
ngraham edited the summary of this revision. (Show Details)Mar 17 2019, 1:24 PM
ngraham updated this revision to Diff 54087.Mar 17 2019, 1:51 PM

Don't show the icon when there are any updates

apol added a comment.Mar 17 2019, 4:57 PM

conceptual +1

discover/qml/UpdatesPage.qml
152 ↗(On Diff #54087)

use page.isBusy so it doesn't have to start looking for the symbol all over the place

318 ↗(On Diff #54087)

Gathering reads super weird to me.

ngraham updated this revision to Diff 54107.Mar 17 2019, 5:05 PM
ngraham marked 2 inline comments as done.

Improve a string and find the property properly

apol accepted this revision.Mar 17 2019, 5:08 PM
This revision is now accepted and ready to land.Mar 17 2019, 5:08 PM
Closed by commit R134:95c39a6f7f2b: Improve update states' UI (authored by ngraham). · Explain WhyMar 17 2019, 5:09 PM
This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Mar 17 2019, 5:38 PM

+1

Maybe the icon can be smaller, but in principle, yes!

rooty added a subscriber: rooty.Mar 17 2019, 5:41 PM

Hey I know this has landed already but how do you feel about the word Retrieving instead of Fetching?

Revision Contents
Changeset List

Diff 54107

View Options

discover/qml/DiscoverWindow.qml

Loading...
View Options

discover/qml/UpdatesPage.qml

Loading...