libdiscover/appstream/OdrsReviewsBackend.cpp
186	Can't you call this at the beginng of the method? Or let it be owned by a `QScopedPointer<QNetworkReply, QScopedPointerDeleteLater> replyPtr(sender());` instead of calling `deleteLater()` explicitly before each return

Use QScopedPointer<QNetworkReply, QScopedPointerDeleteLater>

libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
143 ↗	(On Diff #54015)	This will crash here because it's passed into the connect, so it will be deleted when the function leaves and accessed from the lambda.
156 ↗	(On Diff #54015)	This will crash too.

How about connecting: connect(reply, &QNetworkReply::finished, reply, &QObject::deleteLater); after instantiating and be done with it?

libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
143 ↗	(On Diff #54015)	Just move the `QScopedPointer` into the lambda, which is what I was thinking about (wasn't clear in my comment, sorry)

Fix QScopedPointer

is it ok now ?

This revision is now accepted and ready to land.Mar 23 2019, 6:12 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libdiscover/appstream/OdrsReviewsBackend.cpp (5 lines)
M			libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53990	69a41b4		Mar 16 2019, 8:26 AM	★	★
Diff 2	53998	69a41b4	Fix indent	Mar 16 2019, 9:35 AM	★	★
Diff 3	54015	69a41b4	Use QScopedPointer<QNetworkReply, QScopedPointerDeleteLater>	Mar 16 2019, 2:25 PM	★	★
Diff 4	54387	69a41b4	Fix QScopedPointer	Mar 20 2019, 7:00 AM	★	★
Diff 5	54647	c4e8f04	R134:4adbb68bf40515b034952d73f8a3197035c2d7eb	Mar 24 2019, 9:13 AM	★	★

QNetworkReply was not deleted
ClosedPublic
Actions

Details