delete networkreply
Details
Details
- Reviewers
apol - Group Reviewers
Discover Software Store - Commits
- R134:4adbb68bf405: QNetworkReply was not deleted
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
libdiscover/appstream/OdrsReviewsBackend.cpp | ||
---|---|---|
186 | Can't you call this at the beginng of the method? Or let it be owned by a QScopedPointer<QNetworkReply, QScopedPointerDeleteLater> replyPtr(sender()); instead of calling deleteLater() explicitly before each return |
Comment Actions
How about connecting: connect(reply, &QNetworkReply::finished, reply, &QObject::deleteLater); after instantiating and be done with it?
libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp | ||
---|---|---|
142–143 | Just move the QScopedPointer into the lambda, which is what I was thinking about (wasn't clear in my comment, sorry) |