What I wonder is whether we really need the "Variable" class. Maybe it would be better to just have

• registerExactMatch(QString name, QString description, function)
• registerPrefixMatch(QString prefix, QString description, function)

If such a change would be preferred, then I can easily change the patch.

...and as the unit test currently shows, recursive macro expansion is not supported, but I think it's needed for e.g. %{JS: bla %{...} : %[...}}.

I think without the Variable class it would be nicer.
One can extend it later easier, too, by just adding a new overload with a different function type (if needed).

Unfortunately, I still see one issue: In the unit test, expanding the variable to "World" works, but expanding it to "Smart World" leads to single-quoted text "'Smart World'" because of the space. That of course makes sense, but is not always what you want.

Therefore, I suggest we expand the API as follows:

bool expandVariable(const QString& variable, KTextEditor::View* view, QString& output, KTextEditor::ExpansionMode mode = QuoteWhenNeeded) const;
bool expandText(const QString& text, KTextEditor::View* view, QString& output, KTextEditor::ExpansionMode mode = QuoteWhenNeeded) const;

with

enum class KTextEditor::ExpansionMode { Never, QuoteWhenNeeded }

Any comments?

Hmm, I am actually not sure we want the quoting per default at all.
You use expandMacrosShellQuote, I am not sure that that is that often wanted (at least not if not passing to commandline/shell).
Perhaps the Enum should more state "NoQuoting, ShellQuoting, ..."

Hmm. the Variable class and files is just an artifact now or?

In D19795#432612, @cullmann wrote:

Hmm. the Variable class and files is just an artifact now or?

Yes, it's just used internally. Without it, I'd need to add ugly std::tuple into the QHash. It's still in the KTextEditor namespace though. I can change to KateVariable if you want.

Ok, then I am fine with this beside that I think the Quoting stuff should be more explicit that it is "Shell" quoting.
Isn't it even different for Windows vs. unices?
I still think QuotationMode NoQuoting + ShellQuoting would be more easy to understand. WhenNeeded is a bit unclear for the "when"?

It's committed now:

• quoting is now not supported at all anymore
• expandText() now returns void