kadabash (Tim __)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2018, 8:20 AM (288 w, 3 d)
Availability
Available

Recent Activity

Nov 24 2019

kadabash added a comment to D19793: Enable HiDPI pixmaps.

Yes, that is perfectly fine for me.

Nov 24 2019, 8:09 PM

Sep 13 2019

kadabash added a comment to D19793: Enable HiDPI pixmaps.

Sorry, I don't understand what it is you would like me to do.
I do not have access to a KDE development setup, so I cannot push any new commits.
In my Phabricator account settings, a full name is set, which is not "Kadabash", however.

Sep 13 2019, 10:02 AM

Mar 15 2019

kadabash added a comment to D19793: Enable HiDPI pixmaps.

Here are two screenshots showing the difference of the second change.
The pixelated description text is in the "Name" column of the package list.

Mar 15 2019, 9:23 PM
kadabash updated the diff for D19793: Enable HiDPI pixmaps.

Scale package description text properly

Mar 15 2019, 9:20 PM
kadabash added a comment to D19793: Enable HiDPI pixmaps.

I tested this on Ubuntu 18.10, the difference is clearly visible in the attached screenshots.

Mar 15 2019, 8:06 PM
kadabash requested review of D19793: Enable HiDPI pixmaps.
Mar 15 2019, 8:03 PM

Oct 31 2018

kadabash added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

While adapting the settings window in Cantor to this proposed change I have discovered that it influences the sizeHint() of other (non-modified) pages in the same window. This leads to a worse layout than before.

Oct 31 2018, 11:46 AM · Frameworks

Oct 19 2018

kadabash updated the diff for D16137: Add an option to KConfigDialog to fit page contents horizontally.

Fit page content horizontally *and* vertically

Oct 19 2018, 6:03 PM · Frameworks

Oct 14 2018

kadabash added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone needs to add a new flag, they can add it to that enum and don't need a new parameter.

Am I making sense?

Oct 14 2018, 5:56 PM · Frameworks
kadabash updated the diff for D16137: Add an option to KConfigDialog to fit page contents horizontally.

Generalize page flags to options not related to alignment

Oct 14 2018, 5:52 PM · Frameworks

Oct 12 2018

kadabash added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

Sorry for the duplicate updates, I messed up my Arcanist commands.

Oct 12 2018, 6:49 PM · Frameworks
kadabash updated the diff for D16137: Add an option to KConfigDialog to fit page contents horizontally.

Restore binary compatibility and introduce alignment flags

Oct 12 2018, 6:44 PM · Frameworks
kadabash updated the diff for D16137: Add an option to KConfigDialog to fit page contents horizontally.

Restore binary compatibility and introduce alignment flags

Oct 12 2018, 6:43 PM · Frameworks
kadabash added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

I have to admit, I don't know how to implement a version with flags correctly.

Oct 12 2018, 4:18 PM · Frameworks

Oct 11 2018

kadabash requested review of D16137: Add an option to KConfigDialog to fit page contents horizontally.
Oct 11 2018, 5:55 PM · Frameworks

Oct 9 2018

kadabash added a comment to D16048: Resize the preferences dialogue to avoid horizontal scrolling.

You are right, of course. Magic constants are bad.

Oct 9 2018, 3:38 PM · Okular

Oct 8 2018

kadabash added a comment to D16048: Resize the preferences dialogue to avoid horizontal scrolling.

Screenshot before change:

Oct 8 2018, 4:24 PM · Okular
kadabash requested review of D16048: Resize the preferences dialogue to avoid horizontal scrolling.
Oct 8 2018, 4:18 PM · Okular