Differential D19759

Remove unsupported attributes from QGraphicsWidgets
ClosedPublic
Actions

Authored by pvuorela on Mar 14 2019, 2:42 PM.

Details

Reviewers
boemann
Commits
R8:0e9d73d8ce1e: Remove unsupported attributes from QGraphicsWidgets
Summary

Qt::WA_InputMethodEnabled and WA_StaticContents attributes
are only supported by QWidget, not QGraphicsWidget.
Resulted warnings like
"QGraphicsWidget::setAttribute: unsupported attribute 14".




Don't think this has ever worked as intended.
Diff Detail
Repository 
R8 Calligra 
Lint 
Lint Skipped
 
Unit 
Unit Tests Skipped
 
pvuorela created this revision.Mar 14 2019, 2:42 PM
Restricted Application added a project: Calligra: 3.0.  ·  View Herald TranscriptMar 14 2019, 2:42 PM
Restricted Application added a subscriber: Calligra-Devel-list.  ·  View Herald Transcript
pvuorela requested review of this revision.Mar 14 2019, 2:42 PM
pvuorela updated this revision to Diff 54325.Mar 19 2019, 3:03 PM
pvuorela retitled this revision from Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets to Remove unsupported attributes from QGraphicsWidgets.
pvuorela edited the summary of this revision. (Show Details)
Updated to remove also WA_StaticContents in addition to earlier WA_InputMethodEnabled.
pvuorela added a comment.Apr 4 2019, 9:18 AM
Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().
pvuorela added a comment.Apr 26 2019, 3:01 PM
Second ping for this.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2019, 7:15 AM
Closed by commit R8:0e9d73d8ce1e: Remove unsupported attributes from QGraphicsWidgets (authored by pvuorela).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
Revision Contents
Changeset List
Diff 53885
View Options
sheets/part/CanvasItem.cpp
Loading...
View Options
words/part/KWCanvasItem.cpp
Loading...